HDDS-11223. Fix iteration over ChunkBufferImplWithByteBufferList #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Jul 28, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-11223. Fix iteration over ChunkBufferImplWithByteBufferList
ChunkBufferImplWithByteBufferList.iterate()is broken and returns the result that violates the contract ofChunkBuffer.iterate().As a result, with
hdds.datanode.chunk.data.validation.check=trueit's not possible to put anything into an EC bucket (see details in JIRA).What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11223
How was this patch tested?
Added new unit tests.