HDDS-12081. TestKeyInputStream repeats tests with default container layout

[adoroszlai]

What changes were proposed in this pull request?

Problem:
TestChunkInputStream and TestKeyInputStream repeat tests with default container layout, instead of testing with both FILE_PER_BLOCK and FILE_PER_CHUNK.

Causes:

• The tests set wrong string representation of the configured container layout (since HDDS-4552). Test cluster always falls back to the default layout, FILE_PER_BLOCK.
• KeyValueHandler does not allow creating containers with FILE_PER_CHUNK layout, even if configured correctly (since HDDS-11753).

Fix:

• Change the tests to start the cluster only once, with the default layout.
• Set the layout in datanode configs right before creating data.
• Close existing containers afterwards, to ensure each test writes data to new container, created with the layout being tested.

https://issues.apache.org/jira/browse/HDDS-12081

How was this patch tested?

Added temporary log in KeyValueHandler.handleCreateContainer to show the layout being used.

ozone/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java

Lines 395 to 399 in 0723902

	ContainerLayoutVersion layoutVersion =
	ContainerLayoutVersion.getConfiguredVersion(conf);
	KeyValueContainerData newContainerData = new KeyValueContainerData(
	containerID, layoutVersion, maxContainerSize, request.getPipelineID(),
	getDatanodeId());

CI:
https://github.com/adoroszlai/ozone/actions/runs/12783565176

[jojochuang]

I'm not sure about this.
Once open containers are closed, SCM will recreate open containers. Containers will be created using the layout specified at the DataNodes, which doesn't get updated until the start of the next test.

Wouldn't it make more sense to call closeContainers() after updateConfig()?

[jojochuang]

Also there are a few other tests still using FILE_PER_CHUNK. TestFinalizeBlock is one of them. Should it get rid of duplicate tests that reference FILE_PER_CHUNK?

[adoroszlai]

Thanks @jojochuang for the review, good points. I have updated the patch. (I don't intend to remove usage of FILE_PER_CHUNK from unit tests.)

[jojochuang]

+1

[jojochuang]

Merged. Thanks @adoroszlai for quick update.

[adoroszlai]

Thanks @jojochuang for reviewing and merging this.