Skip to content

Conversation

@Gargi-jais11
Copy link
Contributor

What changes were proposed in this pull request?

Add metrics in DiskBalancerServiceMetrics to record the time spent on container move, for both success and failure case.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12436

How was this patch tested?

The patch was tested manually by running docker cluster and seeing the results at JMX endpoint and prometheus. At prometheus endpoint by querying for disk_balancer_service_metrics_move_success_time_avg_time and disk_balancer_service_metrics_move_failure_time_avg_time it shows the change in graph curves and the average time taken for the successful and failure moves respectively.

"name" : "Hadoop:service=HddsDatanode,name=DiskBalancerServiceMetrics",
    "modelerType" : "DiskBalancerServiceMetrics",
    "tag.Context" : "dfs",
    "tag.Hostname" : "2757e35f9c78",
    "FailureCount" : 6,
    "IdleLoopExceedsBandwidthCount" : 0,
    "IdleLoopNoAvailableVolumePairCount" : 0,
    "MoveFailureTimeNumOps" : 6,
    "MoveFailureTimeAvgTime" : 0.0,
    "MoveSuccessTimeNumOps" : 7,
    "MoveSuccessTimeAvgTime" : 0.0,
    "RunningLoopCount" : 10,
    "SuccessBytes" : 10412359680,
    "SuccessCount" : 7

@Gargi-jais11 Gargi-jais11 changed the base branch from master to HDDS-5713 March 4, 2025 04:29
@Gargi-jais11 Gargi-jais11 changed the title Hdds-12436. [DiskBalancer] Add metrics for time spent by container move HDDS-12436. [DiskBalancer] Add metrics for time spent by container move Mar 4, 2025
@Gargi-jais11 Gargi-jais11 marked this pull request as ready for review March 5, 2025 05:36
Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gargi-jais11 Thanks for the patch. Left some comments.

@ivandika3 ivandika3 requested review from ChenSammi and symious March 6, 2025 01:51
@Gargi-jais11 Gargi-jais11 requested a review from ivandika3 March 6, 2025 09:21
Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Just left few more nits.

Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM +1.

@ivandika3 ivandika3 merged commit d2cd69a into apache:HDDS-5713 Mar 8, 2025
43 checks passed
@ivandika3
Copy link
Contributor

@Gargi-jais11 Thanks for the patch.

Gargi-jais11 added a commit to Gargi-jais11/ozone that referenced this pull request Mar 10, 2025
Gargi-jais11 pushed a commit to Gargi-jais11/ozone that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants