-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-12436. [DiskBalancer] Add metrics for time spent by container move #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ivandika3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gargi-jais11 Thanks for the patch. Left some comments.
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ivandika3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Just left few more nits.
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ivandika3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM +1.
|
@Gargi-jais11 Thanks for the patch. |
…ainer move (apache#8001)" This reverts commit 6e4afc6.
What changes were proposed in this pull request?
Add metrics in DiskBalancerServiceMetrics to record the time spent on container move, for both success and failure case.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12436
How was this patch tested?
The patch was tested manually by running docker cluster and seeing the results at JMX endpoint and prometheus. At prometheus endpoint by querying for
disk_balancer_service_metrics_move_success_time_avg_timeanddisk_balancer_service_metrics_move_failure_time_avg_timeit shows the change in graph curves and the average time taken for the successful and failure moves respectively.