HDDS-12545. [DiskBalancer] Query status and report API doesn't require SCM admin privilege #8112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tejaskriya
reviewed
Mar 20, 2025
Contributor
Tejaskriya
left a comment
Tejaskriya
left a comment
There was a problem hiding this comment.
Thanks for working on this @Gargi-jais11, Left some improvement suggestions below to reduce the code duplication across the various test cases
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
Tejaskriya
reviewed
Mar 20, 2025
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
Gargi-jais11
force-pushed
the
HDDS-12545
branch
from
4fe1627 to
c83fb4e
Compare
ChenSammi
reviewed
Mar 21, 2025
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
Tejaskriya
approved these changes
Mar 21, 2025
Contributor
Tejaskriya
left a comment
Tejaskriya
left a comment
There was a problem hiding this comment.
Thanks for making the changes, LGTM!
ChenSammi
approved these changes
Mar 21, 2025
Contributor
|
Thanks @Gargi-jais11 and @Tejaskriya . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Current all disk balancer requests to SCM will check the admin permission.
It is necessary when it's a write kind operation, start, stop, update.
But it's not necessary to enforce the admin permission on read operation, status, report.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12545
How was this patch tested?
Written robot tests to check for the admin permission on disk balancer requests to scm.
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot