-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-12546. [DiskBalancer] Display bytesMoved instead of VolumeDensity in status output #8150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Mar 26, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
ChenSammi
reviewed
Mar 26, 2025
ChenSammi
reviewed
Mar 26, 2025
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Mar 27, 2025
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java
Outdated
Show resolved
Hide resolved
# Conflicts: # hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerInfo.java # hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java # hadoop-hdds/interface-client/src/main/proto/hdds.proto # hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java # hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerStatus.java # hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java
0f70ae6 to
5d17fc2
Compare
ChenSammi
reviewed
Apr 2, 2025
.../tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestDiskBalancerSubCommand.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 2, 2025
.../tools/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestDiskBalancerSubCommand.java
Outdated
Show resolved
Hide resolved
ChenSammi
approved these changes
Apr 3, 2025
Contributor
ChenSammi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gargi-jais11 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As VolumeDensity is already covered by report sub command, we will show bytesMoved (bytesBalanced) in status command.
Besides, the meaning of VolumeDensity is clear to end user, but the real value indicating is not that straight forward. Use the estimated pending move size(HDDS-12437) will help user to clearly understand how much data size need to move. And this bytesMoved is also a straight forward value, indicating the work disk balancer has done.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12546
How was this patch tested?
Added unit test to test bytesToMoveMB, bytesMovedMB and calculateEstimatedTimeLeft to show reasonable values when bytesToMove and bytesMoved are less than 1MB.
As well as tested manually by running docker cluster locally.