HDDS-12654. [DiskBalancer]Add a hdds.datanode.disk.balancer.stop.after.disk.even property #8239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargi-jais11
force-pushed
the
HDDS-12654
branch
from
f940290 to
3e5ffed
Compare
ChenSammi
reviewed
Apr 16, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 16, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 16, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 16, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 16, 2025
...p-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerCommands.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 16, 2025
hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 21, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 21, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
chungen0126
requested changes
Apr 23, 2025
Contributor
chungen0126
left a comment
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @Gargi-jais11 for the patch.
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Show resolved
Hide resolved
...-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java
Outdated
Show resolved
Hide resolved
Gargi-jais11
force-pushed
the
HDDS-12654
branch
from
4c5ebbc to
d11ca7a
Compare
ChenSammi
reviewed
Apr 29, 2025
ChenSammi
reviewed
Apr 29, 2025
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDiskBalancer.java
Outdated
Show resolved
Hide resolved
added 9 commits
May 9, 2025 21:04
ChenSammi
approved these changes
May 9, 2025
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @Gargi-jais11 , and @chungen0126 for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This hdds.datanode.disk.balancer.stop.after.disk.even means once the disks become even, disk balancer on datanode will stop by itself, also update the on disk diskBalancer.info state.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12654
How was this patch tested?
Added acceptance test and also checked by manual testing on docker cluster.