HDDS-12796. [DiskBalancer] Exclude UNHEALTHY DNs from status subcommand output #8286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Apr 15, 2025
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 15, 2025
...ds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerDeadNodeHandler.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 15, 2025
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Show resolved
Hide resolved
ChenSammi
reviewed
Apr 21, 2025
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DeadNodeHandler.java
Show resolved
Hide resolved
Gargi-jais11
force-pushed
the
HDDS-12796
branch
from
67f9106 to
a256cdf
Compare
ChenSammi
approved these changes
Apr 21, 2025
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @Gargi-jais11 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when any DN goes down or is in Unhealthy State, DiskBalancer reportSubcommand is only showing reports of Healthy DNs which is correct.
But DiskBalancer statusSubCommand is showing even Unhealthy DNs with status as RUNNING which is misleading.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12796
How was this patch tested?
Added unit test.