HDDS-12879. Use AtomicFileOutputStream to write DiskBalancerYAML file #8317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
approved these changes
Apr 24, 2025
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 , @jojochuang for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use AtomicFileOutputStream to write DiskBalancerYaml file.
Because of the following reasons:
Using AtomicFileOutputStream prevents partial or corrupt writes by writing to a temp file and atomically replacing the original.
It will also be consistent with the other yaml files changed in HDDS-12531
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12879
How was this patch tested?
passed existing tests.