HDDS-8781. Allow on demand metadata scanning of open containers #8442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aryangupta1998
left a comment
aryangupta1998
left a comment
There was a problem hiding this comment.
Overall, the changes look good to me!
Some minor comments inline.
...vice/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerScanner.java
Outdated
Show resolved
Hide resolved
...vice/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerScanner.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/hadoop/ozone/dn/scanner/TestOnDemandContainerScannerIntegration.java
Outdated
Show resolved
Hide resolved
errose28
added
the
scanners
Contributor
Author
|
Thanks for the review @aryangupta1998 , I have addressed all the changes you have suggested |
Contributor
|
@ptlrs can you review this? |
adoroszlai
reviewed
Jun 14, 2025
...rc/test/java/org/apache/hadoop/ozone/dn/scanner/TestOnDemandContainerScannerIntegration.java
Outdated
Show resolved
Hide resolved
ptlrs
reviewed
Jun 25, 2025
Contributor
ptlrs
left a comment
ptlrs
left a comment
There was a problem hiding this comment.
Thank you @Tejaskriya for this PR. It looks mostly good.
...vice/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerScanner.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/hadoop/ozone/dn/scanner/TestOnDemandContainerScannerIntegration.java
Outdated
Show resolved
Hide resolved
...vice/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerScanner.java
Outdated
Show resolved
Hide resolved
ptlrs
approved these changes
Jul 10, 2025
Contributor
ptlrs
left a comment
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the changes @Tejaskriya. LGTM.
aryangupta1998
approved these changes
Jul 10, 2025
Contributor
aryangupta1998
left a comment
aryangupta1998
left a comment
There was a problem hiding this comment.
Thanks for the patch @Tejaskriya, LGTM!
Contributor
|
Thanks @Tejaskriya for the patch, @aryangupta1998, @ptlrs for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently on demand scanning does a full check (data and metadata) of closed containers only. Data scan of blocks can only be done on closed containers, but metadata scan can be done on open containers. When an open container is queued for on-demand scanning, the scanner should do a metadata scan instead of ignoring it.
This PR introduces metadata scan for open containers as well.
What is the link to the Apache JIRA
HDDS-8781
How was this patch tested?
Updated existing unit and integration tests