HDDS-13011. Disable Snapshot DAG Pruner Thread. #8529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @swamirishi , @jojochuang, @smengcl can you take a look at this? |
Contributor
|
Thanks @SaketaChalamchala . Pls fix the title to match the original jira. This should be revisited after HDDS-13009 is merged. |
SaketaChalamchala
changed the title
Contributor
|
The PR removes the pruner thread not disabling it. Apart from that the PR looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After snapshot compaction is implemented although the content of the snapshot dbs will remain the same, the file names might change. We will need to disable DAG pruner and not remove source files of older compactions to be able to perform diff.
With #8214 the storage footprint of the SST backup dir will be reduced so we this change shouldn't affect the storage footprint adversely.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13011
How was this patch tested?
Manual test