HDDS-10931. Schedule on demand scan of containers after import #8550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tejaskriya
added
the
scanners
Contributor
aryangupta1998
left a comment
aryangupta1998
left a comment
There was a problem hiding this comment.
Thanks for the patch @Tejaskriya.
Overall, the patch looks good, some minor comments inline!
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java
Outdated
Show resolved
Hide resolved
...rvice/src/test/java/org/apache/hadoop/ozone/container/replication/TestContainerImporter.java
Outdated
Show resolved
Hide resolved
...rvice/src/test/java/org/apache/hadoop/ozone/container/replication/TestContainerImporter.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @aryangupta1998, I have addressed all the comments! |
Contributor
|
@ptlrs can you review this? |
adoroszlai
reviewed
Jun 14, 2025
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java
Outdated
Show resolved
Hide resolved
...rvice/src/test/java/org/apache/hadoop/ozone/container/replication/TestContainerImporter.java
Outdated
Show resolved
Hide resolved
ptlrs
reviewed
Jun 25, 2025
Contributor
ptlrs
left a comment
ptlrs
left a comment
There was a problem hiding this comment.
Thanks @Tejaskriya for the PR.
I have a question about a scenario where the scan may be skipped post-import.
.../src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OnDemandContainerDataScanner.java
Outdated
Show resolved
Hide resolved
ptlrs
approved these changes
Jul 10, 2025
Contributor
ptlrs
left a comment
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the changes @Tejaskriya.
The changes for resetting the timestamp LGTM.
aryangupta1998
approved these changes
Jul 10, 2025
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java
Show resolved
Hide resolved
errose28
reviewed
Jul 10, 2025
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Aside from the minor discussion on debug logging LGTM as well.
...r-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the reviews @aryangupta1998 @ptlrs @errose28 ! |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To make sure that containers are replicated successfully, we should scan the container soon after importing it. If there is an issue, SCM will be notified and replication can be retried.
This PR schedules a async scan of the container after import.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10931
How was this patch tested?
Added unit test in TestContainerImporter