Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Add alias --om-service-id for OM service ID option in ozone admin om updateranger, so that we can use $OM_HA_PARAM (which is set to --om-service-id <service> for OM HA environment)
  • Tweak ozone-secure-tenant.robot to allow running it with both real Ranger (in ozonesecure-ha env.) and without (in ozonesecure env.):
    • Use RANGER_ENDPOINT_URL to distinguish between the two cases
    • Extract variables for tenant and user
    • Disable test case that attempts to delete non-empty tenant, this does not work with Ranger (see HDDS-13361)
  • Implement toString() for some value classes in MultiTenantAccessController for better debug
  • Rename variable ${testuser} to ${user} in kinit.robot, because Kinit test user sets ${TEST_USER}, and variable names in Robot are case-insensitive and ignore underscores. Thus, ${testuser} and ${TEST_USER} are the same, i.e. the keyword overwrites kinit.robot's variable.

https://issues.apache.org/jira/browse/HDDS-13354

How was this patch tested?

Existing test.

With Ranger:
https://github.com/adoroszlai/ozone/actions/runs/16004570857/job/45148864306#step:13:1063

Without Ranger:
https://github.com/adoroszlai/ozone/actions/runs/16004570857/job/45148864252#step:13:376

@adoroszlai adoroszlai self-assigned this Jul 1, 2025
@adoroszlai adoroszlai added the test label Jul 1, 2025
@adoroszlai adoroszlai requested a review from smengcl July 1, 2025 18:33
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @adoroszlai !

@adoroszlai adoroszlai merged commit 0694480 into apache:master Jul 10, 2025
42 checks passed
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review.

@adoroszlai adoroszlai deleted the HDDS-13354 branch July 10, 2025 01:10
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants