Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Run TestOmSnapshotFileSystem* with a single cluster to reduce setup time.

https://issues.apache.org/jira/browse/HDDS-13402

How was this patch tested?

Before:

[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.06 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystemLegacy
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.22 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystemFsoWithLinkedBuckets
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.92 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystemLegacyWithLinkedBuckets
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.47 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFileSystemFso

After:

[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.89 s -- in org.apache.hadoop.ozone.om.snapshot.SnapshotTests$OmSnapshotFileSystemLegacyWithLinkedBuckets
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.40 s -- in org.apache.hadoop.ozone.om.snapshot.SnapshotTests$OmSnapshotFileSystemLegacy
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.18 s -- in org.apache.hadoop.ozone.om.snapshot.SnapshotTests$OmSnapshotFileSystemFsoWithLinkedBuckets
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.30 s -- in org.apache.hadoop.ozone.om.snapshot.SnapshotTests$OmSnapshotFileSystemFso
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.50 s -- in org.apache.hadoop.ozone.om.snapshot.TestOzoneSnapshotsNonHA

Total 92.5 seconds instead of 168.67.

https://github.com/adoroszlai/ozone/actions/runs/16119193466

@adoroszlai adoroszlai self-assigned this Jul 7, 2025
@adoroszlai adoroszlai added the test label Jul 7, 2025
@kerneltime
Copy link
Contributor

org.apache.hadoop.hdds.scm.node.TestDecommissionAndMaintenance
Error:  org.apache.hadoop.hdds.scm.node.TestDecommissionAndMaintenance.testDecommissioningNodesCompleteDecommissionOnSCMRestart -- Time elapsed: 125.9 s <<< ERROR!
java.util.concurrent.TimeoutException: 
Timed out waiting for condition. Thread diagnostics:
Timestamp: 2025-07-07 03:53:43,872

@jojochuang jojochuang added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jul 7, 2025
@jojochuang jojochuang requested review from jojochuang and smengcl July 7, 2025 16:25
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai ! Looks good code wise.

Was the timeout issue mentioned above related?

@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review.

Was the timeout issue mentioned above related?

No, I only changed test code and TestDecommissionAndMaintenance is a separate test (apparently still somewhat flaky).

@adoroszlai adoroszlai merged commit 490e6bb into apache:master Jul 11, 2025
53 of 54 checks passed
@adoroszlai adoroszlai deleted the HDDS-13402 branch July 11, 2025 07:22
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517 test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants