Skip to content

Conversation

@Gargi-jais11
Copy link
Contributor

What changes were proposed in this pull request?

  • ozone tenant delete fails with TENANT_NOT_EMPTY if user is assigned to the tenant, but OM deletes associated policies from Ranger first.
  • Thus, after ozone tenant user revoke, the tenant is empty, but ozone tenant delete still fails, now due to 404 Not Found error from Ranger, when OM tries to delete policies.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13361

How was this patch tested?

Passed Existing Acceptance Test.

@Gargi-jais11 Gargi-jais11 marked this pull request as ready for review July 10, 2025 08:48
@Gargi-jais11 Gargi-jais11 marked this pull request as draft July 10, 2025 08:56
@adoroszlai
Copy link
Contributor

Thanks @Gargi-jais11 for the patch. In HDDS-13354 I assumed ozone admin om updateranger would work in non-HA case by taking OM address from the config, but apparently it does not. To fix the test, please:

  1. Move these two keywords from upgrade/lib.robot to a new file admincli/lib.resource.
    Get OM Service ID
    ${service_id} = Get Environment Variable OM_SERVICE_ID ${EMPTY}
    RETURN ${service_id}
    Get OM Service Param
    ${service_id} = Get OM Service ID
    IF '${service_id}' == ''
    RETURN --service-host om
    ELSE
    RETURN --service-id '${service_id}'
    END
  2. Make sure to add license header and *** Settings *** section with Library OperatingSystem, which is required for Get OM Service ID.
  3. Import the new file by adding Resource ../admincli/lib.resource in both upgrade/lib.robot and security/ozone-secure-tenant.robot.
  4. Make Trigger and wait call Get OM Service Param. Replace ${OM_HA_PARAM} with its return value.

@Gargi-jais11 Gargi-jais11 requested a review from adoroszlai July 11, 2025 07:59
@adoroszlai adoroszlai marked this pull request as ready for review July 11, 2025 11:46
@adoroszlai
Copy link
Contributor

Thanks @Gargi-jais11 for updating the patch.

@smengcl please take a look

Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gargi-jais11 for the patch.

@adoroszlai adoroszlai merged commit a1e7513 into apache:master Jul 12, 2025
53 checks passed
@adoroszlai
Copy link
Contributor

Thanks @Gargi-jais11 for the patch, @smengcl for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants