Skip to content

Conversation

@devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-13424. Use lsof instead of fuser to find if file is used

Please describe your PR in detail:

  • The AbstractTestChunkManager.isFileNotInUse() method uses fuser command to determine if a file is in use or not
  • However in different OS environments this might not be present, for example in a minimal RHEL 8 environment fuser is not present by default and needs to be installed via psmisc package.
  • An alternative to this is to use the lsof command to figure out if the file is being used.
  • This PR changes fuser to instead use lsof to run the tests to ensure compatibility in different OS environments

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13424

How was this patch tested?

Patch was tested manually by running the affected unit tests

@devabhishekpal devabhishekpal marked this pull request as ready for review July 11, 2025 12:38
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What OS was tested?

I can confirm lsof -f -- <path> works on Mac and RHEL 9.3. Haven't verified with other platforms

@ivandika3 ivandika3 added the test label Jul 11, 2025
@adoroszlai adoroszlai merged commit 9aad5bc into apache:master Jul 12, 2025
38 of 39 checks passed
errose28 added a commit to errose28/ozone that referenced this pull request Jul 22, 2025
* master: (90 commits)
  HDDS-13308. OM should expose Ratis config for increasing pending write limits (apache#8668)
  HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. (apache#8787)
  HDDS-13429. Custom metadata headers with uppercase characters are not supported (apache#8805)
  HDDS-13448. DeleteBlocksCommandHandler thread stop for normal exception (apache#8816)
  HDDS-13346. Intermittent failure in TestCloseContainer#testContainerChecksumForClosedContainer (apache#8771)
  HDDS-13125. Add metrics for monitoring the SST file pruning threads. (apache#8764)
  HDDS-13367. [Docs] User doc for container balancer. (apache#8726)
  HDDS-13200. OM RocksDB Grafana Dashbroad shows no data on all panels (apache#8577)
  HDDS-13428. Recon - Retrigger of build whole NSSummary tree task submission inconsistency. (apache#8793)
  HDDS-13378. [Docs] Add a Production page under Getting Started (apache#8734)
  HDDS-13403. [Docs] Make feature proposal process more visible. (apache#8758)
  HDDS-11797. Remove cyclic dependency between SCMSafeModeManager and SafeModeRules (apache#8782)
  HDDS-13213. KeyDeletingService should limit task size by both key count and serialized size. (apache#8757)
  HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig (apache#8760)
  HDDS-13405. ozone admin container create runs forever without kinit (apache#8765)
  HDDS-11514. Set optimal default values for delete configurations based on live cluster testing. (apache#8766)
  HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option (apache#8791)
  HDDS-11679. Support multiple S3Gs in MiniOzoneCluster (apache#8733)
  HDDS-13424. Use lsof instead of fuser to find if file is used in AbstractTestChunkManager (apache#8790)
  HDDS-13427. Bump awssdk to 2.31.78 (apache#8792)
  ...
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants