HDDS-13496. Intermittent fork exit timeout in TestOzoneClientFactory #8853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombizita
approved these changes
Aug 1, 2025
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for the fix @adoroszlai!
Contributor
Author
|
Thanks @dombizita for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Surefire fork for
TestOzoneClientFactorywas intermittently not exiting:I think this may be due to not stopping the cluster. However, the test exercises Ozone client, not the factory. Nor does it require a fresh cluster. So instead of fixing it within the existing class, the test case is moved to
TestSecureOzoneRpcClient. This also saves some time due to one fewer cluster to start.https://issues.apache.org/jira/browse/HDDS-13496
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/16462030194/job/46531742303
Flaky test check:
https://github.com/adoroszlai/ozone/actions/runs/16462952219