HDDS-12439. [DiskBalancer] Reserve committed space during volume choosing process #8882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
force-pushed
the
HDDS-12439-policy
branch
from
94068f4 to
2d65e92
Compare
ChenSammi
force-pushed
the
HDDS-12439-policy
branch
from
2d65e92 to
7c6ccc0
Compare
Contributor
Author
|
Gone through the PR with @symious offline. Here are the changes recommended, |
symious
approved these changes
Aug 8, 2025
Contributor
symious
left a comment
symious
left a comment
There was a problem hiding this comment.
LGTM. Thanks for all the great improvements.
Contributor
Author
|
Thanks @symious for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12439
How was this patch tested?
new and existing unit test