HDDS-13611. [DiskBalancer] Inconsistent VolumeDataDensity calculations between SCM and DN and incorrect EstBytesToMove #8972
+240
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenSammi
reviewed
Aug 28, 2025
...ain/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 28, 2025
...c/main/java/org/apache/hadoop/ozone/container/diskbalancer/VolumeDataDensityCalculation.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 28, 2025
...c/main/java/org/apache/hadoop/ozone/container/diskbalancer/VolumeDataDensityCalculation.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 28, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Aug 28, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Sep 24, 2025
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Sep 24, 2025
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
ChenSammi
reviewed
Sep 24, 2025
| */ | ||
| public static ImmutableList<HddsVolume> getImmutableVolumeSet(MutableVolumeSet volumeSet) { | ||
| // Create an immutable copy of the volume list at this point in time | ||
| List<HddsVolume> volumes = StorageVolumeUtil.getHddsVolumesList(volumeSet.getVolumesList()); |
Contributor
There was a problem hiding this comment.
Can we use StorageVolume instead of HddsVolume? For getCurrentUsage() is available in StorageVolume.
Contributor
Author
There was a problem hiding this comment.
We cannot use StorageVolume instead of HddsVolume although getCurrentUsage() is available in StorageVolume but ** getCommittedBytes() ** is only available in HddsVolume which is needed for calculation.
ChenSammi
reviewed
Sep 24, 2025
...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
Outdated
Show resolved
Hide resolved
Gargi-jais11
force-pushed
the
HDDS-13611
branch
from
9756211 to
e48be9d
Compare
added 6 commits
September 26, 2025 16:41
…sToMove with DefaultVolumeChoosingPolicy # Conflicts: # hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java
…e calculation on DN side # Conflicts: # hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
Gargi-jais11
force-pushed
the
HDDS-13611
branch
from
96ead2f to
6026ffa
Compare
Contributor
|
Thanks @Gargi-jais11 , the last patch looks good to me, +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This ticket fixes inconsistencies in VolumeDataDensity calculations between SCM and DN causing misleading reports.
Although volumeDataDensity for the datanode is 0.0 still it is started and showing containers moved.
Estimated bytes moved and estimated time left is 0 although it is moving containers.
Proposed Solution:
VolumeDataDensity calculation (on SCM side in DiskBalancerManager ), EstimatedBytesToMove calculation should be aligned with DefaultVolumeChoosingPolicy calculation.{}
VolumeDataDensity calculation should be done on the DN side so that it considers all the ongoing operations and then correctly report it to the SCM.
And this VolumeDataDensity calculation should be standAlone utility on datanode side that can calculate VolumeDataDensity regardless of diskbalancer state (stopped or running) .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13611
How was this patch tested?
passed existing test.