HDDS-13649. [DiskBalancer] Refine Disk Balancer CLI, Documentation, and Naming for Improved Usability

[Gargi-jais11]

What changes were proposed in this pull request?

1. naming of variable DatanodeDiskBalancerInfoRequest should start with small letter, same for DatanodeDiskBalancerInfoResponse
2. Update the config description added in HDDS-13497. [DiskBalancer] Add new property "hdds.datanode.disk.balancer.enabled" #8869 to indicate the same.
3. Update the CLI help message to indicate the same.
4. Hide the CLI so it does not appear in help messages.
5. fix misleading description for running on multipleDatanodes.
6. make all the CLI flags kebab-case. They are using a mix of kebab and camel case right now.
7. remove crlStatusReport not part of diskBalancer Changes.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13649

How was this patch tested?

Tested locally on docker.

bash-5.1$ ozone admin datanode -h
Usage: ozone admin datanode [-hV] [--verbose] [COMMAND]
Datanode specific operations
  -h, --help      Show this help message and exit.
  -V, --version   Print version information and exit.
      --verbose   More verbose output. Show the stack trace of the errors.
Commands:
  list          List info of datanodes
  decommission  Decommission a datanode
  maintenance   Put a datanode into Maintenance Mode
  recommission  Return a datanode to service
  status        Show status of datanodes
  usageinfo     List usage information (such as Capacity, SCMUsed, Remaining)
                  of a datanode by IP address or Host name or UUID
bash-5.1$ ozone admin datanode diskbalancer -h
Usage: ozone admin datanode diskbalancer [-hV] [--verbose] [COMMAND]
DiskBalancer specific operations. It is disabled by deafult. To enable it, set
'hdds.datanode.disk.balancer.enabled' as true
  -h, --help      Show this help message and exit.
  -V, --version   Print version information and exit.
      --verbose   More verbose output. Show the stack trace of the errors.
Commands:
  start   Start DiskBalancer
  stop    Stop DiskBalancer
  update  Update DiskBalancer Configuration
  report  Get Datanode Volume Density Report
  status  Get Datanode DiskBalancer Status for inServiceHealthy DNs
bash-5.1$ 

bash-5.1$ ozone admin datanode diskbalancer update -t 20 -b 30 -p 12 -d ozone-datanode-4,ozone-datanode-5,ozone-datanode-3 
Update DiskBalancer Configuration on datanode(s):
ozone-datanode-4
ozone-datanode-5
ozone-datanode-3
bash-5.1$ ozone admin datanode diskbalancer status
Status result:
Datanode                            Status          Threshold(%)    BandwidthInMB   Threads      SuccessMove  FailureMove  BytesMoved(MB)  EstBytesToMove(MB) EstTimeLeft(min)
ozone-datanode-3.ozone_default      STOPPED         20.0000         30              12           0            0            0               0               0              
ozone-datanode-1.ozone_default      STOPPED         10.0000         10              5            0            0            0               0               0              
ozone-datanode-2.ozone_default      STOPPED         10.0000         10              5            0            0            0               0               0              
ozone-datanode-5.ozone_default      STOPPED         20.0000         30              12           0            0            0               0               0              
ozone-datanode-4.ozone_default      STOPPED         20.0000         30              12           0            0            0               0               0              

Note: Estimated time left is calculated based on the estimated bytes to move and the configured disk bandwidth.

[sumitagrawl]

LGTM