HDDS-13665. [DiskBalancer] Cleanup for multiple DiskBalancerReport sent to SCM #9034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitagrawl
reviewed
Sep 17, 2025
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@Gargi-jais11 thanks for working over this, given a comment
...c/main/java/org/apache/hadoop/ozone/container/common/report/DiskBalancerReportPublisher.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In HeartbeatEndpointTask there are two reports sent to scm by DN for diskBalancer, one is by addReport using DiskBalancerReportPublisher and second is by addDiskBalancerReport .
DiskBalancer Report should be sent actively only when diskBalancer is running or paused by node state and if diskBalancer is stopped then report should only be sent if there is any changes since last published report.
Proposed Solution:
Remove addDiskBalancerReport .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13665
How was this patch tested?
Passed Existing tests.