-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-13667. [DiskBalancer] Improve DiskBalancer CLI message for failed commands #9091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sarvekshayr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @Gargi-jais11.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
...i-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerCommonOptions.java
Show resolved
Hide resolved
|
Thanks for updating the patch. Please change the log message from the first output in the PR description. |
sumitagrawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gargi-jais11 Given minor comment
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
sumitagrawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @Gargi-jais11 for the contribution, and @sumitagrawl for the review. |
What changes were proposed in this pull request?
Currently DiskBalancer start, stop and update command is send only to IN_SERVICE_HEALTHY DN but user has no info about this so improve cli output message to show as below:
When start, stop and update command is sent to a specific DN which is not IN_SERVICE_HEALTHY, command should be rejected same as when sent to all DN.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13667
How was this patch tested?
Updated existing Integration Test
TestDiskBalancerDuringDecommissionAndMaintenance.Also tested manually on docker-cluster: