HDDS-13722. Refactor duplicate code in OMDirectoriesPurgeRequestWithFSO

[unknowntpo]

Extract duplicate code for processing keys and acquiring locks into a helper method. Both subdirectory and subfile processing loops had identical code for:

• Converting protobuf key to OmKeyInfo
• Creating path and delete keys
• Creating volBucketPair

Introduced ProcessedKeyInfo helper class to encapsulate all extracted information (keyInfo, deleteKey, volumeName, bucketName, volBucketPair) and processDeleteKey method to eliminate code duplication.

What changes were proposed in this pull request?

Extract duplicated code.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13722

How was this patch tested?

UT: TestOMDirectoriesPurgeRequestAndResponse

[adoroszlai]

Thanks @unknowntpo for the patch. Please enable the build-branch workflow in your fork.

[adoroszlai]

Suppression doesn't seem to be necessary.

Suggested change

	@SuppressWarnings("visibilitymodifier")
	private static class ProcessedKeyInfo {
	final OmKeyInfo keyInfo;
	final String deleteKey;
	final String volumeName;
	final String bucketName;
	final Pair<String, String> volBucketPair;
	private static class ProcessedKeyInfo {
	private final OmKeyInfo keyInfo;
	private final String deleteKey;
	private final String volumeName;
	private final String bucketName;
	private final Pair<String, String> volBucketPair;

[unknowntpo]

Ok, build-branch is enabled. And suggestion is applied.

[Copilot]

Pull Request Overview

This PR refactors duplicate code in OMDirectoriesPurgeRequestWithFSO by extracting common key processing logic into a reusable helper method. The changes eliminate code duplication between subdirectory and subfile processing loops while maintaining the same functionality.

• Extracted common key processing logic into processDeleteKey helper method
• Introduced ProcessedKeyInfo helper class to encapsulate processed key information
• Replaced duplicate code blocks in both subdirectory and subfile processing loops

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The ProcessedKeyInfo class exposes all fields as package-private, but they should be private with getter methods for better encapsulation. Direct field access breaks encapsulation principles.

[unknowntpo]

Getter is too verbose.

[Copilot]

The constructor accepts both individual volumeName/bucketName parameters and a volBucketPair containing the same information, creating redundancy. Consider creating the volBucketPair internally from volumeName and bucketName to eliminate this duplication.

[unknowntpo]

ok, fixed at 05ffdc8

[jojochuang]

+1

[jojochuang]

Merged. Thanks @unknowntpo for contribution and @adoroszlai for review.