-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-13598. Send disk balancer command directly to datanode #9256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ChenSammi , @sumitagrawl , @szetszwo Could you please review this patch? |
...src/main/java/org/apache/hadoop/ozone/admin/diskbalancer/AbstractDiskBalancerSubCommand.java
Outdated
Show resolved
Hide resolved
...dmin/src/main/java/org/apache/hadoop/ozone/admin/diskbalancer/DiskBalancerCommonOptions.java
Outdated
Show resolved
Hide resolved
...-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DatanodeCommands.java
Show resolved
Hide resolved
...admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStartSubcommand.java
Show resolved
Hide resolved
...p-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocolPB/DiskBalancerProtocolPB.java
Show resolved
Hide resolved
...src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerProtocolServer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerProtocolServer.java
Outdated
Show resolved
Hide resolved
|
@Gargi-jais11 , thanks for working on this, overall it looks good to me.
Is the output a mistake? |
Yes, I think while pasting this happened. I will correct it here. |
|
The last patch LGTM + 1. Wait for the CI to pass. |
What changes were proposed in this pull request?
Support to direct send disk balancer command to DN(Client-DN) instead of Client-SCM-DN .
This JIRA covers:
Implementation of direct client-to-DN communication protocol
Removal of rest SCM DiskBalancer code and modification of all UT and IT tests will be done as part of HDDS-13878 issue.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13598
How was this patch tested?
Green CI : https://github.com/Gargi-jais11/ozone/actions/runs/19130217959
New Unit Test
TestDiskBalancerProtocolServerOld Unit, Integration and
testdiskbalancer.robottests will be updated as part of HDDS-13878.Below is cli output for direct client to DN communication:
start, stop and update command :