HDDS-14030. Add ConfigGroup prefix to all configs where missing #9460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargi-jais11
suggested changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Thanks @Russole for working on this patch.
I have checked all the places configKey include configGroup(Prefix).
...p-hdds/framework/src/main/java/org/apache/hadoop/hdds/fs/DedicatedDiskSpaceUsageFactory.java
Show resolved
Hide resolved
adoroszlai
reviewed
Dec 8, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch.
Comment on lines
35
to
37
| public static final String OM_CLIENT_RPC_TIME_OUT = "rpc.timeout"; | ||
| public static final String OM_CLIENT_RPC_TIME_OUT = "ozone.om.client.rpc.timeout"; | ||
| public static final String OM_TRASH_EMPTIER_CORE_POOL_SIZE | ||
| = "trash.core.pool.size"; | ||
| = "ozone.om.client.trash.core.pool.size"; |
Contributor
There was a problem hiding this comment.
Please inline these constants (use string value directly in key). They are not used elsewhere.
Comment on lines
34
to
40
| public static final String SCM_CLIENT_RPC_TIME_OUT = "rpc.timeout"; | ||
| public static final String SCM_CLIENT_RPC_TIME_OUT = "hdds.scmclient.rpc.timeout"; | ||
| public static final String SCM_CLIENT_FAILOVER_MAX_RETRY = | ||
| "failover.max.retry"; | ||
| "hdds.scmclient.failover.max.retry"; | ||
| public static final String SCM_CLIENT_MAX_RETRY_TIMEOUT = | ||
| "max.retry.timeout"; | ||
| "hdds.scmclient.max.retry.timeout"; | ||
| public static final String SCM_CLIENT_RETRY_INTERVAL = | ||
| "failover.retry.interval"; | ||
| "hdds.scmclient.failover.retry.interval"; |
Contributor
There was a problem hiding this comment.
Please inline these constants.
| public static final String PREFIX = "hdds.datanode.replication"; | ||
| public static final String STREAMS_LIMIT_KEY = "streams.limit"; | ||
| public static final String QUEUE_LIMIT = "queue.limit"; | ||
| public static final String QUEUE_LIMIT = "hdds.datanode.replication.queue.limit"; |
Contributor
There was a problem hiding this comment.
Please inline this constant.
Contributor
Author
|
Thank you @Gargi-jais11 and @adoroszlai for the helpful review comments. |
adoroszlai
approved these changes
Dec 8, 2025
Contributor
|
Thanks @Russole for the patch, @Gargi-jais11 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR standardizes configuration key definitions across the codebase.
Many configuration classes annotated with
@ConfigGroup(prefix = "...")still use unprefixed keys in their@Config(key = ...)entries (e.g., "shutdown.timeout" instead of "ozone.service.shutdown.timeout").This patch updates those entries to explicitly include the full prefix in the key literal.
Benefits of this change include:
Only keys missing the prefix were updated.
Keys already using a fully-qualified name were left unchanged.
No functional behavior is modified.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14030
How was this patch tested?
All GitHub CI checks passed successfully. No functional behavior is changed.