HDDS-14164. Remove DatanodeDiskBalancerInfoType. #9492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
The removal of DatanodeDiskBalancerInfoType simplifies the DiskBalancer RPC interface and cleans up both client and server-side logic. All dependent code paths and tests appear to be updated correctly.
LGTM!
@ChenSammi Please review this patch.
Gargi-jais11
approved these changes
Dec 13, 2025
ChenSammi
approved these changes
Dec 15, 2025
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for this improvement, and @Gargi-jais11 for the review.
Contributor
Author
|
@Gargi-jais11 , @ChenSammi , thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DatanodeDiskBalancerInfoType is used in DiskBalancerReportSubcommand and DiskBalancerStatusSubcommand. However, it is not needed. STATUS is a super set of REPORT – it includes additional details not included in REPORT. The servers could simply build the reply proto with all the additional details in order to simplify the code. Then, the commands could choose what to display.
What is the link to the Apache JIRA
HDDS-14164
How was this patch tested?
By updating existing tests.