[core] Support time travel to tag in batch mode #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
force-pushed
the
travel-tag
branch
2 times, most recently
from
0a02d1f to
3cfd6fc
Compare
JingsongLi
reviewed
Jun 21, 2023
| + "produces a snapshot specified by \"scan.snapshot-id\" but does not read new changes."); | ||
| + "produces a snapshot specified by \"scan.snapshot-id\" but does not read new changes."), | ||
|
|
||
| FROM_TAG( |
Contributor
There was a problem hiding this comment.
Can we just use from-snapshot?
| @@ -69,6 +70,7 @@ public abstract class AbstractFileStoreScan implements FileStoreScan { | |||
|
|
|||
| private Predicate partitionFilter; | |||
| private Long specifiedSnapshotId = null; | |||
Contributor
There was a problem hiding this comment.
Can we just remove this specifiedSnapshotId and use specifiedSnapshot?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1404
Tests
StaticFromTagStartingScannerTestBatchFileStoreITCase#testTimeTravelReadSparkTimeTravelITCaseAPI and Format
New core option:
scan.tag-nameDocumentation