[core] orc/parquet reader obtain the fileSize from metadata #2918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wg1026688210
changed the title
wg1026688210
changed the title
wg1026688210
force-pushed
the
core/reduce_nm_io
branch
from
c476c2c to
1a0599f
Compare
2 tasks
wg1026688210
changed the title
JingsongLi
reviewed
Mar 17, 2024
| /** A factory to create {@link RecordReader} for file. */ | ||
| public interface FormatReaderFactory extends Serializable { | ||
|
|
||
| RecordReader<InternalRow> createReader(FileIO fileIO, Path file) throws IOException; |
Contributor
There was a problem hiding this comment.
Can you introduce a Context for FormatReaderFactory?
wg1026688210
force-pushed
the
core/reduce_nm_io
branch
from
1a0599f to
a716834
Compare
JingsongLi
approved these changes
Mar 19, 2024
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @wg1026688210
zhu3pang
pushed a commit
to zhu3pang/incubator-paimon
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to reduce the access of FileSystem, the format reader of orc/parquet use the fileSize from metadata
Linked issue: related #2978
Tests
KeyValueFileReadWriteTest#testReaderUseFileSizeFromMetadata
API and Format
Documentation