[core] Introduce FileSource to DataFileMeta #3363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
May 22, 2024
| String compression, | ||
| CoreOptions options) { | ||
| CoreOptions options, | ||
| boolean isCompact) { |
Contributor
There was a problem hiding this comment.
Maybe just pass FileSource? For all places in this PR.
Contributor
|
+1 |
2 tasks
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
joyCurry30
pushed a commit
to joyCurry30/paimon
that referenced
this pull request
May 30, 2024
yuzelin
pushed a commit
to yuzelin/paimon
that referenced
this pull request
Apr 14, 2025
This reverts commit 2c38b03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is the first step of the #3178. Introduce the FileSource to DataFileMeta
Tests
API and Format
Yes, the DataFileMeta is changed, but it will keep compatible with default null value.
Documentation