[core] Introduce ChangelogDeletion to Expiration #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
May 23, 2024
| .maxDeletes(options.snapshotExpireLimit()) | ||
| .retainMin(options.changelogNumRetainMin()) | ||
| .retainMax(options.changelogNumRetainMax()); | ||
| newExpireChangelog().config(options.expireConfig().build()); |
Contributor
There was a problem hiding this comment.
reuse options.expireConfig().build().
|
|
||
| protected final Map<BinaryRow, Set<Integer>> deletionBuckets; | ||
| protected final Executor ioExecutor; | ||
| protected boolean changelogDecoupled; |
Contributor
There was a problem hiding this comment.
changelogDecoupled who use this?
Contributor
Author
There was a problem hiding this comment.
For example, SnapshotDeletion will use this to determine whether to clean changelog manifests. It will also be used in ChangelogDeletion in following PR.
Contributor
There was a problem hiding this comment.
but there is no assignment for it.
maybe you need to add it in next pr.
Contributor
Author
There was a problem hiding this comment.
There is setChangelogDecoupled . I feel difficult to make this field final, so I add a set method for it.
paimon-core/src/main/java/org/apache/paimon/operation/FileDeletionBase.java
Show resolved
Hide resolved
Aitozi
force-pushed
the
delta-2
branch
4 times, most recently
from
03e0fb1 to
621a34e
Compare
JingsongLi
reviewed
May 24, 2024
| public Predicate<ManifestEntry> dataFileSkipper(Snapshot fromSnapshot) throws Exception { | ||
| return dataFileSkipper(Collections.singletonList(fromSnapshot)); | ||
| } | ||
| protected Collection<ManifestEntry> readMergedDataFiles(Snapshot snapshot) throws IOException { |
Contributor
Author
There was a problem hiding this comment.
The latest commit is reverted, please take a look again when you are free.
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
joyCurry30
pushed a commit
to joyCurry30/paimon
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is the second step of #3178 to simply the clean up logic of snapshot and changelog
Tests
API and Format
Documentation