[core] Fix read row position with parquet when filter push down #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
force-pushed
the
dv/test-parquet-filter-push-down
branch
from
366ee3a to
6f0040c
Compare
Zouxxyy
force-pushed
the
dv/test-parquet-filter-push-down
branch
from
a2fbf01 to
bb59905
Compare
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Parquet write & expose row index in block metadata since 1.12.3 (paimon use 1.13.1) see https://issues.apache.org/jira/browse/PARQUET-2117, we can use it to computer row position when blocks are filtered. When row index was not found in block metadata, skip applying filter in order to get the correct row position
Tests
API and Format
Documentation