[core] Support creating Iceberg metadata based on old ones #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Jul 12, 2024
| if (baseSnapshot == null) { | ||
| createMetadataWithoutBase(currentSnapshot); | ||
| } else { | ||
| createMetadataWithBase(committable, currentSnapshot, baseSnapshot); |
Contributor
There was a problem hiding this comment.
pass Set<BinaryRow> modifiedPartitions to createMetadataWithBase.
| .dataSplits(); | ||
| Map<String, Pair<RawFile, BinaryRow>> currentRawFiles = new HashMap<>(); | ||
| for (DataSplit dataSplit : dataSplits) { | ||
| if (dataSplit.rawConvertible() && modifiedPartitions.contains(dataSplit.partition())) { |
Contributor
There was a problem hiding this comment.
without deletion vectors, please add tests.
| } | ||
| } | ||
|
|
||
| public static Object toObject(DataType type, byte[] bytes) { |
JingsongLi
approved these changes
Aug 19, 2024
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Looks good to me!
Let's keep moving forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In #3731 we introduce
IcebergCommitCallbackto create Iceberg metadata. In this PR we improve this class so that it can reuse Iceberg manifest files created before to create new Iceberg metadata.Tests
Unit tests.
API and Format
No changes in Paimon format.
Documentation
Document will be added later.