[parquet] Fix that cannot read parquet ROW<DECIMAL> data #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzelin
force-pushed
the
fix_parquet_dec
branch
2 times, most recently
from
f24adb2 to
8fcb15f
Compare
yuzelin
force-pushed
the
fix_parquet_dec
branch
from
8fcb15f to
a120c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In
NestedColumnReader#readRow, we need to know the length of nested vectors. Generally, it can be gotten fromAbstractHeapVectorbutParquetDecimalVectoris not anAbstractHeapVector. This PR fix it.Also remove two unused classes:
RowColumnReader,RowPosition.Tests
API and Format
Documentation