[core] Drop stats in manifest file reading #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
force-pushed
the
remove_whole_bucket_filter
branch
from
e3e5267 to
92baf51
Compare
JingsongLi
force-pushed
the
remove_whole_bucket_filter
branch
from
c677009 to
f5405a9
Compare
JingsongLi
changed the title
Contributor
|
Very thanks for @JingsongLi do this work! |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We planned to remove the statistical information when reading the file, but this optimization was hindered by the need for statistical information later for whole bucket filter.
In this PR, we refactor this logical to drop stats and compute filter selected result, in this way, we can keep whole bucket filter.
Tests
API and Format
Documentation