Skip to content

[core] Check file size after write bundle of records #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 2 commits into from
Dec 11, 2024
Merged

[core] Check file size after write bundle of records #4685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aaba5b
[core] Check file size after write bundle of records
leaves12138 Dec 11, 2024
3d201f0
fix comment
leaves12138 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions paimon-core/src/main/java/org/apache/paimon/io/RollingFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ public long targetFileSize() {
return targetFileSize;
}

@VisibleForTesting
boolean rollingFile() throws IOException {
private boolean rollingFile(boolean forceCheck) throws IOException {
return currentWriter.reachTargetSize(
recordCount % CHECK_ROLLING_RECORD_CNT == 0, targetFileSize);
forceCheck || recordCount % CHECK_ROLLING_RECORD_CNT == 0, targetFileSize);
}

@Override
Expand All @@ -81,7 +80,7 @@ public void write(T row) throws IOException {
currentWriter.write(row);
recordCount += 1;

if (rollingFile()) {
if (rollingFile(false)) {
closeCurrentWriter();
}
} catch (Throwable e) {
Expand All @@ -105,7 +104,7 @@ public void writeBundle(BundleRecords bundle) throws IOException {
currentWriter.writeBundle(bundle);
recordCount += bundle.rowCount();

if (rollingFile()) {
if (rollingFile(true)) {
closeCurrentWriter();
}
} catch (Throwable e) {
Expand Down
Loading