Skip to content

[core] fix the issue where streaming reading of overwrite data would fail when retract type data appeared. #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Dec 13, 2024
Merged

[core] fix the issue where streaming reading of overwrite data would fail when retract type data appeared. #4697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../main/java/org/apache/paimon/table/source/splitread/IncrementalChangelogReadProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,20 @@ private SplitRead<InternalRow> create(Supplier<MergeFileSplitRead> supplier) {
ConcatRecordReader.create(
() ->
new ReverseReader(
read.createNoMergeReader(
read.createMergeReader(
split.partition(),
split.bucket(),
split.beforeFiles(),
split.beforeDeletionFiles()
.orElse(null),
true)),
false)),
() ->
read.createNoMergeReader(
read.createMergeReader(
split.partition(),
split.bucket(),
split.dataFiles(),
split.deletionFiles().orElse(null),
true));
false));
return unwrap(reader);
};

Expand Down
37 changes: 37 additions & 0 deletions ...flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/ReadWriteTableITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,43 @@ public void testStreamingReadOverwriteWithoutPartitionedRecords() throws Excepti
streamingItr.close();
}

@Test
public void testStreamingReadOverwriteWithDeleteRecords() throws Exception {
String table =
createTable(
Arrays.asList("currency STRING", "rate BIGINT", "dt STRING"),
Collections.singletonList("currency"),
Collections.emptyList(),
Collections.emptyList(),
streamingReadOverwrite);

insertInto(
table,
"('US Dollar', 102, '2022-01-01')",
"('Yen', 1, '2022-01-02')",
"('Euro', 119, '2022-01-02')");

bEnv.executeSql(String.format("DELETE FROM %s WHERE currency = 'Euro'", table)).await();

checkFileStorePath(table, Collections.emptyList());

// test projection and filter
BlockingIterator<Row, Row> streamingItr =
testStreamingRead(
buildQuery(table, "currency, rate", "WHERE dt = '2022-01-02'"),
Collections.singletonList(changelogRow("+I", "Yen", 1L)));

insertOverwrite(table, "('US Dollar', 100, '2022-01-02')", "('Yen', 10, '2022-01-01')");

validateStreamingReadResult(
streamingItr,
Arrays.asList(
changelogRow("-D", "Yen", 1L), changelogRow("+I", "US Dollar", 100L)));
assertNoMoreRecords(streamingItr);

streamingItr.close();
}

@Test
public void testUnsupportStreamingReadOverwriteWithoutPk() {
assertThatThrownBy(
Expand Down
Loading