Skip to content

[hive] Batch list tables and skip checking table exists in filesystem with hive catalog #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 3 commits into from
Dec 19, 2024
Merged

[hive] Batch list tables and skip checking table exists in filesystem with hive catalog #4737

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ffe615
[hive] Skip checking table exists in filesystem when show tables
Zouxxyy Dec 18, 2024
f925d83
add batch list
Zouxxyy Dec 18, 2024
ae9e57e
1
Zouxxyy Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,17 +436,13 @@ protected void alterDatabaseImpl(String name, List<PropertyChange> changes) {
@Override
protected List<String> listTablesImpl(String databaseName) {
try {
List<String> allTables = clients.run(client -> client.getAllTables(databaseName));
List<String> result = new ArrayList<>(allTables.size());
for (String t : allTables) {
try {
Identifier identifier = new Identifier(databaseName, t);
Table table = getHmsTable(identifier);
if (isPaimonTable(identifier, table)
|| (!formatTableDisabled() && isFormatTable(table))) {
result.add(t);
}
} catch (TableNotExistException ignored) {
List<String> tableNames = clients.run(client -> client.getAllTables(databaseName));
List<Table> hmsTables =
clients.run(client -> client.getTableObjectsByName(databaseName, tableNames));
List<String> result = new ArrayList<>(hmsTables.size());
for (Table table : hmsTables) {
if (isPaimonTable(table) || (!formatTableDisabled() && isFormatTable(table))) {
result.add(table.getTableName());
}
}
return result;
Expand Down Expand Up @@ -478,7 +474,7 @@ public TableSchema getDataTableSchema(Identifier identifier) throws TableNotExis

private TableSchema getDataTableSchema(Identifier identifier, Table table)
throws TableNotExistException {
if (!isPaimonTable(identifier, table)) {
if (!isPaimonTable(table)) {
throw new TableNotExistException(identifier);
}

Expand Down Expand Up @@ -870,7 +866,7 @@ private Table renameHiveTable(Identifier fromTable, Identifier toTable) {
protected void alterTableImpl(Identifier identifier, List<SchemaChange> changes)
throws TableNotExistException, ColumnAlreadyExistException, ColumnNotExistException {
Table table = getHmsTable(identifier);
if (!isPaimonTable(identifier, table)) {
if (!isPaimonTable(table)) {
throw new UnsupportedOperationException("Only data table support alter table.");
}

Expand Down Expand Up @@ -1044,12 +1040,6 @@ public Table getHmsTable(Identifier identifier) throws TableNotExistException {
}
}

private boolean isPaimonTable(Identifier identifier, Table table) {
return isPaimonTable(table)
&& tableExistsInFileSystem(
getTableLocation(identifier, table), identifier.getBranchNameOrDefault());
}

private static boolean isPaimonTable(Table table) {
boolean isPaimonTable =
INPUT_FORMAT_CLASS_NAME.equals(table.getSd().getInputFormat())
Expand Down
Loading