Skip to content

[hotfix] Fix typo in NestedColumnReader and NestedPrimitiveColumnReader #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Dec 23, 2024
Merged

[hotfix] Fix typo in NestedColumnReader and NestedPrimitiveColumnReader #4752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions paimon-format/src/main/java/org/apache/paimon/format/parquet/reader/NestedColumnReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ private Pair<LevelDelegation, WritableColumnVector> readRow(
}

if (hasNull) {
setFieldNullFalg(isNull, heapRowVector);
setFieldNullFlag(isNull, heapRowVector);
}
return Pair.of(levelDelegation, heapRowVector);
}
Expand Down Expand Up @@ -202,7 +202,7 @@ private Pair<LevelDelegation, WritableColumnVector> readMap(
}

if (collectionPosition.getIsNull() != null) {
setFieldNullFalg(collectionPosition.getIsNull(), mapVector);
setFieldNullFlag(collectionPosition.getIsNull(), mapVector);
}

mapVector.setLengths(collectionPosition.getLength());
Expand Down Expand Up @@ -240,7 +240,7 @@ private Pair<LevelDelegation, WritableColumnVector> readArray(
}

if (collectionPosition.getIsNull() != null) {
setFieldNullFalg(collectionPosition.getIsNull(), arrayVector);
setFieldNullFlag(collectionPosition.getIsNull(), arrayVector);
}
arrayVector.setLengths(collectionPosition.getLength());
arrayVector.setOffsets(collectionPosition.getOffsets());
Expand All @@ -266,7 +266,7 @@ private Pair<LevelDelegation, WritableColumnVector> readPrimitive(
return Pair.of(reader.getLevelDelegation(), writableColumnVector);
}

private static void setFieldNullFalg(boolean[] nullFlags, AbstractHeapVector vector) {
private static void setFieldNullFlag(boolean[] nullFlags, AbstractHeapVector vector) {
for (int index = 0; index < vector.getLen() && index < nullFlags.length; index++) {
if (nullFlags[index]) {
vector.setNullAt(index);
Expand Down
2 changes: 1 addition & 1 deletion ...at/src/main/java/org/apache/paimon/format/parquet/reader/NestedPrimitiveColumnReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ private int readPageIfNeed() throws IOException {
// Compute the number of values we want to read in this page.
if (readState.valuesToReadInPage == 0) {
int pageValueCount = readPage();
// 返回当前 page 的数据量
// return value count in current page
if (pageValueCount < 0) {
// we've read all the pages; this could happen when we're reading a repeated list
// and we
Expand Down
Loading