Skip to content

[core] SortLookupStoreWriter should support empty record #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Dec 25, 2024
Merged

[core] SortLookupStoreWriter should support empty record #4777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion paimon-common/src/main/java/org/apache/paimon/lookup/sort/BlockWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,11 @@ public int memory() {

public MemorySlice finish() throws IOException {
if (positions.isEmpty()) {
throw new IllegalStateException();
// Do not use alignment mode, as it is impossible to calculate how many records are
// inside when reading
aligned = false;
}

if (aligned) {
block.writeInt(alignedSize);
} else {
Expand Down
18 changes: 18 additions & 0 deletions paimon-common/src/test/java/org/apache/paimon/lookup/sort/SortLookupStoreFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,24 @@ public void testNormal() throws IOException {
assertThat(cacheManager.indexCache().asMap()).isEmpty();
}

@TestTemplate
public void testEmpty() throws IOException {
CacheManager cacheManager = new CacheManager(MemorySize.ofMebiBytes(1));
SortLookupStoreFactory factory =
new SortLookupStoreFactory(Comparator.naturalOrder(), cacheManager, 1024, compress);

SortLookupStoreWriter writer =
factory.createWriter(file, createBloomFiler(bloomFilterEnabled));
Context context = writer.close();

SortLookupStoreReader reader = factory.createReader(file, context);
byte[] bytes = toBytes(rnd.nextInt(VALUE_COUNT));
assertThat(reader.lookup(bytes)).isNull();
reader.close();
assertThat(cacheManager.dataCache().asMap()).isEmpty();
assertThat(cacheManager.indexCache().asMap()).isEmpty();
}

@TestTemplate
public void testIntKey() throws IOException {
RowCompactedSerializer keySerializer =
Expand Down
Loading