Skip to content

[Bug] overwrite is true when commit change log #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 2 commits into from
Jan 6, 2025
Merged

[Bug] overwrite is true when commit change log #4838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a795ca3
overwrite is true when commit change log
jerry-024 Jan 6, 2025
8f91469
add ut
jerry-024 Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-core/src/main/java/org/apache/paimon/utils/SnapshotManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ public List<Snapshot> findSnapshotsForIdentifiers(
}

public void commitChangelog(Changelog changelog, long id) throws IOException {
fileIO.writeFile(longLivedChangelogPath(id), changelog.toJson(), false);
fileIO.writeFile(longLivedChangelogPath(id), changelog.toJson(), true);
}

/**
Expand Down
12 changes: 12 additions & 0 deletions paimon-core/src/test/java/org/apache/paimon/utils/SnapshotManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;

/** Tests for {@link SnapshotManager}. */
public class SnapshotManagerTest {
Expand Down Expand Up @@ -398,4 +399,15 @@ public void testLongLivedChangelog() throws Exception {
Assertions.assertThat(snapshotManager.latestSnapshotId()).isEqualTo(10);
Assertions.assertThat(snapshotManager.changelog(1)).isNotNull();
}

@Test
public void testCommitChangelogWhenSameChangelogCommitTwice() throws IOException {
FileIO localFileIO = LocalFileIO.create();
SnapshotManager snapshotManager =
new SnapshotManager(localFileIO, new Path(tempDir.toString()));
long id = 1L;
Changelog changelog = createChangelogWithMillis(id, 1L);
snapshotManager.commitChangelog(changelog, id);
assertDoesNotThrow(() -> snapshotManager.commitChangelog(changelog, id));
}
}
Loading