[iceberg] support migration for iceberg hive-catalog and introduce flink procedure and action #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
LsomeYeah
force-pushed
the
migrate-iceberg-hive-1
branch
from
d43625c to
f73ecd1
Compare
tsreaper
reviewed
Feb 10, 2025
Comment on lines
68
to
78
| // isPartitioned, icebergIsHive, paimonIsHive, isNamedArgument | ||
| return Stream.of( | ||
| Arguments.of(true, false, false, true), | ||
| Arguments.of(false, false, false, true), | ||
| Arguments.of(true, true, false, true), | ||
| Arguments.of(false, true, false, true), | ||
| Arguments.of(true, true, false, false), | ||
| Arguments.of(false, true, false, false), | ||
| Arguments.of(true, false, true, true), | ||
| Arguments.of(true, true, true, true)); | ||
| } |
Contributor
There was a problem hiding this comment.
No need to run all combinations each time. Generate random values for each argument each time. If there is a bug, some PR will trigger it.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll make it a random test.
LsomeYeah
force-pushed
the
migrate-iceberg-hive-1
branch
from
7f33534 to
e8b3880
Compare
…g to paimon # Conflicts: # paimon-core/src/main/java/org/apache/paimon/iceberg/metadata/IcebergDataField.java
…g table in hive is external
…mon table to source table if migrating success [core] alter access permisssion of getDataTypeFromType()
# Conflicts: # paimon-flink/paimon-flink-common/src/main/resources/META-INF/services/org.apache.paimon.factories.Factory # Conflicts: # paimon-flink/paimon-flink-common/src/main/resources/META-INF/services/org.apache.paimon.factories.Factory
…IcebergTableProcedureITCase
LsomeYeah
force-pushed
the
migrate-iceberg-hive-1
branch
from
e8b3880 to
6b84657
Compare
tsreaper
approved these changes
Feb 13, 2025
This was referenced Feb 13, 2025
This was referenced Feb 13, 2025
JackeyLee007
pushed a commit
to JackeyLee007/paimon
that referenced
this pull request
Feb 14, 2025
…ink procedure and action (apache#4878) This closes apache#4878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
In pr #4639, we had supported the core ability of migrating iceberg table to paimon table. This pr aims to:
Up to now, you can migrate iceberg table to paimon table by invoking the corresponding procedure or action.
Tests
org.apache.paimon.hive.procedure.MigrateTableProcedureITCase#testMigrateIcebergTableProcedure
org.apache.paimon.hive.procedure.MigrateTableProcedureITCase#testMigrateIcebergTableAction
API and Format
Documentation