Skip to content

Conversation

@Sxnan
Copy link
Contributor

@Sxnan Sxnan commented Jul 16, 2025

Purpose

Linked issue: close #5781

According to Flink's Catalog#listTables method's Javadoc, the FlinkCatalog#listTables method should return all tables and views under a certain database.

Tests

API and Format

Documentation

@Sxnan
Copy link
Contributor Author

Sxnan commented Jul 16, 2025

Hi @yunfengzhou-hub, can you review this PR?

@yunfengzhou-hub
Copy link
Contributor

Hi @Sxnan Thanks for the PR. It might be better to also check if other APIs have similar syntax gap and fix them altogether.

Besides, could you add some tests to verify the correctness of this change?

@Sxnan Sxnan force-pushed the flink-listTable branch 2 times, most recently from 6e8c0b5 to e0773e8 Compare July 22, 2025 03:27
@Sxnan
Copy link
Contributor Author

Sxnan commented Jul 22, 2025

@yunfengzhou-hub I checked the other APIs and only listTable has the problem. I added the test to verify that the listTable returns views as well.

@yunfengzhou-hub
Copy link
Contributor

@yunfengzhou-hub I checked the other APIs and only listTable has the problem. I added the test to verify that the listTable returns views as well.

It seems that FlinkCatalog#alterTable does not support alter Views yet. But different from listTables, this method could explicitly throw exception instead of returning a wrong response, so the support would be more adding a new feature than fixing a bug. Thus we can consider add such supports in future PRs.

@Sxnan Sxnan force-pushed the flink-listTable branch from e0773e8 to ee2d0d1 Compare July 22, 2025 10:05
@Sxnan Sxnan requested a review from yunfengzhou-hub July 23, 2025 01:21
Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@JingsongLi JingsongLi merged commit c91e35c into apache:master Jul 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The syntax of listTables() in Flink and Paimon does not match

3 participants