[core] RESTCatalog: add DLF OSS endpoint support and improve configuration merge #6232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Sep 10, 2025
|
|
||
| return builder.build(); | ||
| // Handle special case: dlf.oss-endpoint should override fs.oss.endpoint | ||
| String dlfOssEndpoint = result.get(DLF_OSS_ENDPOINT.key()); |
Contributor
There was a problem hiding this comment.
Can you just modify RESTTokenFileIO? RESTUtil.merge should be a very simple method, just updates merge into targets.
Member
Author
There was a problem hiding this comment.
Can you just modify
RESTTokenFileIO?RESTUtil.mergeshould be a very simple method, justupdatesmerge intotargets.
Sure, updated.
jerry-024
added a commit
to jerry-024/paimon
that referenced
this pull request
Sep 15, 2025
* upstream/master: (23 commits) [flink] Use Paimon format table read for flink (apache#6246) [core] Ensure system tables use the correct identifier for loadTableToken in RESTTokenFileIO. (apache#6247) [spark] Enhance v1 write merge schema test coverage (apache#6249) [spark] Eliminate duplicate convertLiteral invocations (apache#6250) [python] Fix failing to read 1000cols (apache#6244) [python] Expose CatalogFactory and Schema directly (apache#6243) [doc] Modify Python API to JVM free (apache#6242) [python] Fix multiple write brefore once commit (apache#6241) [core] Support push down branchesTable by branchName (apache#6231) [cdc] Fix PostgreSQL DECIMAL type conversion issue (apache#6239) [arrow] Optimize Arrow string write performance (apache#6240) [core] Fix checkpoint recovery failure for compacted changelog files (apache#6173) [core] RESTCatalog: add DLF OSS endpoint support and improve configuration merge (apache#6232) [core] fix RESTCatalog#listViews for system database (apache#6233) [core] Introduce 'ignore-update-before' to ignore UD only (apache#6235) [python] Fix DLF partition statistical error (apache#6237) [python] Add _VALUE_STATS_COLS param to fix parse wrong bytes (apache#6234) [ci] Rename to Python Check Code Style and Test [python] Rename binary row to generic row [hotfix] Remove methods in SchemaManager for SchemasTable ...
zhuyufeng0809
pushed a commit
to zhuyufeng0809/flink-table-store
that referenced
this pull request
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using Paimon with DLF (Data Lake Formation) server, the server passes default OSS endpoint values (e.g., fs.oss.endpoint=oss-cn-hangzhou-internal.aliyuncs.com) through tokens. However, these default internal endpoints are not accessible in all client environments, causing connectivity issues. The client-provided options should take precedence over server defaults, but the previous merge logic didn't handle this correctly. This PR introduced DLF_OSS_ENDPOINT configuration option in RESTCatalogOptions to allow clients to specify their preferred OSS endpoint.
Tests
org.apache.paimon.utils.RESTUtilTest