Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,15 @@ private void refreshToken() {
if (apiInstance == null) {
apiInstance = new RESTApi(catalogContext.options(), false);
}
GetTableTokenResponse response = apiInstance.loadTableToken(identifier);
Identifier tableIdentifier = identifier;
if (identifier.isSystemTable()) {
tableIdentifier =
new Identifier(
identifier.getDatabaseName(),
identifier.getTableName(),
identifier.getBranchName());
}
GetTableTokenResponse response = apiInstance.loadTableToken(tableIdentifier);
LOG.info(
"end refresh data token for identifier [{}] expiresAtMillis [{}]",
identifier,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1313,6 +1313,18 @@ void testRefreshFileIO() throws Exception {
RESTToken fileDataToken = fileIO.validToken();
RESTToken serverDataToken = getDataTokenFromRestServer(identifier);
assertEquals(serverDataToken, fileDataToken);

// Test system table FileIO refresh
Identifier systemTableIdentifier =
Identifier.create(
identifier.getDatabaseName(), identifier.getTableName() + "$snapshots");
Table systemTable = catalog.getTable(systemTableIdentifier);

// Verify system table uses the same FileIO as origin table
assertThat(systemTable.fileIO()).isInstanceOf(RESTTokenFileIO.class);
RESTTokenFileIO systemTableFileIO = (RESTTokenFileIO) systemTable.fileIO();
RESTToken systemTableToken = systemTableFileIO.validToken();
assertEquals(serverDataToken, systemTableToken);
}
}

Expand All @@ -1339,6 +1351,41 @@ void testRefreshFileIOWhenExpired() throws Exception {
RESTToken nextFileDataToken = fileIO.validToken();
assertEquals(newDataToken, nextFileDataToken);
assertEquals(true, nextFileDataToken.expireAtMillis() - fileDataToken.expireAtMillis() > 0);

// Test system table FileIO refresh when expired
Identifier systemTableIdentifier =
Identifier.create(
identifier.getDatabaseName(), identifier.getTableName() + "$snapshots");
Table systemTable = catalog.getTable(systemTableIdentifier);

// Verify system table FileIO can refresh token properly
assertThat(systemTable.fileIO()).isInstanceOf(RESTTokenFileIO.class);
RESTTokenFileIO systemTableFileIO = (RESTTokenFileIO) systemTable.fileIO();

// Set an even newer token to test refresh
RESTToken newerDataToken =
new RESTToken(
ImmutableMap.of("akId", "akId", "akSecret", UUID.randomUUID().toString()),
System.currentTimeMillis() + 5000_000L);
setDataTokenToRestServerForMock(identifier, newerDataToken);

// Verify system table can get the newest token
RESTToken systemTableRefreshedToken = systemTableFileIO.validToken();
assertEquals(newerDataToken, systemTableRefreshedToken);
assertEquals(
true,
systemTableRefreshedToken.expireAtMillis() - nextFileDataToken.expireAtMillis()
> 0);

// Test with different system table types
Identifier manifestsTableIdentifier =
Identifier.create(
identifier.getDatabaseName(), identifier.getTableName() + "$manifests");
Table manifestsTable = catalog.getTable(manifestsTableIdentifier);
assertThat(manifestsTable.fileIO()).isInstanceOf(RESTTokenFileIO.class);
RESTTokenFileIO manifestsTableFileIO = (RESTTokenFileIO) manifestsTable.fileIO();
RESTToken manifestsTableToken = manifestsTableFileIO.validToken();
assertEquals(newerDataToken, manifestsTableToken);
}

@Test
Expand Down
Loading