Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Conversation

@majetideepak
Copy link

Fixed bug and added a test case


TYPED_TEST_CASE(TestPrimitiveWriter, TestTypes);

typedef TestPrimitiveWriter<Int32Type> TestNullValuesWriter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use using.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wesm
Copy link
Member

wesm commented Sep 15, 2016

+1

@asfgit asfgit closed this in 942f2ae Sep 15, 2016
@majetideepak majetideepak deleted the PARQUET-719 branch September 22, 2016 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants