This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-720: Mark ScanAllValues as inline to prevent link error #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reader.h is included in multiple cpp files, it causes a linker error because ScanAllValues is defined in multiple TUs
Member
|
Yes, please move the function to a |
flode
changed the title
flode
changed the title
Member
|
@flode Can you fix the line lengths reported in Travis? Then this is ready to merge. |
This was referenced Sep 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reader.h is included in multiple cpp files, it causes a linker error
because ScanAllValues is defined in multiple TUs
An alternative solution would be to move ScanAllValues to a separate cpp file.
Should I open a JIRA for this?