This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-946: Add ReadRowGroup and num_row_group methods to arrow::FileReader #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The size of code duplications is far less than I would have expected ;) |
asfgit
pushed a commit
to apache/arrow
that referenced
this pull request
Apr 6, 2017
requires PARQUET-946 apache/parquet-cpp#291 cc @cpcloud @jreback @mrocklin Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #494 from wesm/ARROW-771 and squashes the following commits: 126789a [Wes McKinney] Fix docstring 1009423 [Wes McKinney] Add read_row_group / num_row_groups to ParquetFile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of room for improvement / further refactoring here -- the assumption that an entire column in a file is being read runs very deep in the Arrow reader, so I tried to do the minimum work to decouple the row group iteration. There's some code duplication in ReadRowGroup, but we should maybe save further cleanup for a future patch.