PARQUET-2290: Add CI for Hadoop 2#1076
Merged
Fokko merged 1 commit intoapache:masterfrom Apr 23, 2023
Merged
Conversation
4dab2dc to
ebd6393
Compare
Fokko
commented
Apr 19, 2023
| import org.apache.hadoop.fs.GlobPattern; | ||
|
|
||
| import com.google.re2j.Pattern; | ||
| import com.google.re2j.PatternSyntaxException; |
Contributor
Author
There was a problem hiding this comment.
This caused issues:
[ERROR] /Users/fokkodriesprong/Desktop/parquet-mr/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java:[55,49] incompatible types: java.util.regex.Pattern cannot be converted to com.google.re2j.Pattern
Different libraries are used in Hadoop 2 and 3. I think it makes sense to remove this class since it is already marked deprecated for a very long time.
Contributor
Author
There was a problem hiding this comment.
I've removed the static function since it isn't being used in the project.
2cf9975 to
79148e5
Compare
79148e5 to
ffdf693
Compare
wgtmac
approved these changes
Apr 23, 2023
Fokko
added a commit
to Fokko/parquet-mr
that referenced
this pull request
Apr 25, 2023
Fokko
added a commit
that referenced
this pull request
Apr 26, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
While upgrading Parquet in Iceberg, I noticed that we broke compatibility. Iceberg is still at Hadoop 2.7.3. The
hasCapabilitymethod that is used in #951 is not available in Hadoop <2.9.x. There is no serious workaround. I think it is good to add this CI to at least know the lower bound Hadoop 2 version that we're still supporting.Jira
Tests
Commits
Documentation