PARQUET-2043: Fail for undeclared dependencies#916
Merged
gszadovszky merged 1 commit intoapache:masterfrom Aug 16, 2021
Merged
Conversation
The purpose of this change is to fail the build if some classes are used from not direct dependencies. Only classes from direct dependencies shall be used. Also fixed some references that broke this rule.
shangxinli
approved these changes
Aug 11, 2021
shangxinli
pushed a commit
that referenced
this pull request
Sep 11, 2021
The purpose of this change is to fail the build if some classes are used from not direct dependencies. Only classes from direct dependencies shall be used. Also fixed some references that broke this rule.
shangxinli
added a commit
that referenced
this pull request
Sep 13, 2021
This reverts commit f5595fe.
shangxinli
added a commit
that referenced
this pull request
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to fail the build if some classes are
used from not direct dependencies. Only classes from direct
dependencies shall be used.
Also fixed some references that broke this rule.
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation