PARQUET-2064: Make Range public accessible in RowRanges#921
Merged
gszadovszky merged 2 commits intoapache:parquet-1.12.xfrom Aug 16, 2021
Merged
PARQUET-2064: Make Range public accessible in RowRanges#921gszadovszky merged 2 commits intoapache:parquet-1.12.xfrom
gszadovszky merged 2 commits intoapache:parquet-1.12.xfrom
Conversation
gszadovszky
requested changes
Aug 10, 2021
| final long from; | ||
| final long to; | ||
| public final long from; | ||
| public long to; |
Contributor
There was a problem hiding this comment.
to should also be final.
| } | ||
|
|
||
| public List<Range> getRanges() { | ||
| return ranges; |
Contributor
There was a problem hiding this comment.
I don't like returning ranges directly. This is a mutable list so the caller can modify it without any control. I would suggest wrapping it into an unmodifiable list.
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. After this PR, I will change the master branch also.
Contributor
There was a problem hiding this comment.
Oh, just realized this is not on master. Usually, we are doing the other way around. Push to master then backport to other branches. But this way should be fine as well. We do not have too many PRs ongoing.
gszadovszky
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation