[PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.#922
Merged
gszadovszky merged 1 commit intoapache:masterfrom Aug 16, 2021
Merged
[PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.#922gszadovszky merged 1 commit intoapache:masterfrom
gszadovszky merged 1 commit intoapache:masterfrom
Conversation
gszadovszky
approved these changes
Aug 11, 2021
Contributor
gszadovszky
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
shangxinli
reviewed
Aug 11, 2021
| usedMem == 0 ? | ||
| props.getMaxRowCountForPageSizeCheck() | ||
| : (long) rows / usedMem * remainingMem; | ||
| : rows * remainingMem / usedMem; |
Contributor
There was a problem hiding this comment.
Should we worry about overflow by (rows * remainingMem)?
Contributor
There was a problem hiding this comment.
I've felt it as a low risk. We are talking about pages here so neither the row count nor the used memory should be too high that this would overflow.
Member
Author
There was a problem hiding this comment.
Same as gszadovszky +1
Contributor
|
@shangxinli, I'm merging this. Let's see how it is working. |
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Sep 9, 2021
shangxinli
pushed a commit
that referenced
this pull request
Sep 9, 2021
sunchao
pushed a commit
to sunchao/parquet-mr
that referenced
this pull request
Mar 3, 2022
…e. (apache#922) (cherry picked from commit 6e72dd4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
https://issues.apache.org/jira/browse/PARQUET-2073
Tests
Commits
Documentation